cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 15:43:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Adding a small contribution relation to my experience with interfaces

Geolffrey Mena 2022-08-28 10:33:12 -06:00
parent d2c1267c3d
commit c46981f249
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CodeReviewComments.md

@ -352,7 +352,7 @@ implementing package should return concrete (usually pointer or struct)
types: that way, new methods can be added to implementations without types: that way, new methods can be added to implementations without
requiring extensive refactoring. requiring extensive refactoring.
Do not define interfaces on the implementor side of an API "for mocking"; Do not define interfaces on the `implementor` side of an API "for mocking";
instead, design the API so that it can be tested using the public API of instead, design the API so that it can be tested using the public API of
the real implementation. the real implementation.
@ -362,6 +362,7 @@ let alone what methods it ought to contain.
If you need to inject a dependency into private methods consider not using interfaces as there is no ambiguity in the methods over which you have control of what is received, don't add unnecessary abstractions. The exception is the case where an abstraction is actually required to "group objects into their common behaviors". If you need to inject a dependency into private methods consider not using interfaces as there is no ambiguity in the methods over which you have control of what is received, don't add unnecessary abstractions. The exception is the case where an abstraction is actually required to "group objects into their common behaviors".
Avoid returning interfaces as this would cause an "indirection" problem by limiting access to public attributes in the structure. Use this approach in specific cases such as strict encapsulation.
``` go ``` go
package consumer // consumer.go package consumer // consumer.go