cybercyst/jj
1
0
Fork 0
mirror of https://github.com/martinvonz/jj.git synced 2025-05-14 11:44:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

merged_tree: use merged_tree_entry_diff() in stream version

Browse Source
This commit is contained in:
Yuya Nishihara 2023-11-30 14:56:32 +09:00
parent 97a260b1bf
commit 076b49b610
1 changed files with 47 additions and 51 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

98
lib/src/merged_tree.rs
View File

@ -1029,59 +1029,55 @@ impl<'matcher> TreeDiffStreamImpl<'matcher> {
} }
}; };
for basename in merged_tree_basenames(&tree1, &tree2) { for (basename, value_before, value_after) in merged_tree_entry_diff(&tree1, &tree2) {
let value_before = tree1.value(basename); let path = dir.join(basename);
let value_after = tree2.value(basename); let before = value_before.to_merge();
if value_after != value_before { let after = value_after.to_merge();
let path = dir.join(basename); let tree_before = before.is_tree();
let before = value_before.to_merge(); let tree_after = after.is_tree();
let after = value_after.to_merge(); // Check if trees and files match, but only if either side is a tree or a file
let tree_before = before.is_tree(); // (don't query the matcher unnecessarily).
let tree_after = after.is_tree(); let tree_matches =
// Check if trees and files match, but only if either side is a tree or a file (tree_before || tree_after) && !self.matcher.visit(&path).is_nothing();
// (don't query the matcher unnecessarily). let file_matches = (!tree_before || !tree_after) && self.matcher.matches(&path);
let tree_matches =
(tree_before || tree_after) && !self.matcher.visit(&path).is_nothing();
let file_matches = (!tree_before || !tree_after) && self.matcher.matches(&path);
// Replace trees or files that don't match by `Merge::absent()` // Replace trees or files that don't match by `Merge::absent()`
let before = if (tree_before && tree_matches) || (!tree_before && file_matches) { let before = if (tree_before && tree_matches) || (!tree_before && file_matches) {
before before
} else { } else {
Merge::absent() Merge::absent()
}; };
let after = if (tree_after && tree_matches) || (!tree_after && file_matches) { let after = if (tree_after && tree_matches) || (!tree_after && file_matches) {
after after
} else { } else {
Merge::absent() Merge::absent()
}; };
if before.is_absent() && after.is_absent() { if before.is_absent() && after.is_absent() {
continue; continue;
}
// If the path was a tree on either side of the diff, read those trees.
if tree_matches {
let before_tree_future = Self::tree(
tree1.store().clone(),
self.legacy_format_before,
path.clone(),
before.clone(),
);
let after_tree_future = Self::tree(
tree2.store().clone(),
self.legacy_format_after,
path.clone(),
after.clone(),
);
let both_trees_future =
async { futures::try_join!(before_tree_future, after_tree_future) };
self.pending_trees
.push_back((path.clone(), Box::pin(both_trees_future)));
}
self.items
.insert(DiffStreamKey::normal(path), Ok((before, after)));
} }
// If the path was a tree on either side of the diff, read those trees.
if tree_matches {
let before_tree_future = Self::tree(
tree1.store().clone(),
self.legacy_format_before,
path.clone(),
before.clone(),
);
let after_tree_future = Self::tree(
tree2.store().clone(),
self.legacy_format_after,
path.clone(),
after.clone(),
);
let both_trees_future =
async { futures::try_join!(before_tree_future, after_tree_future) };
self.pending_trees
.push_back((path.clone(), Box::pin(both_trees_future)));
}
self.items
.insert(DiffStreamKey::normal(path), Ok((before, after)));
} }
} }