cybercyst/jj
1
0
Fork 0
mirror of https://github.com/martinvonz/jj.git synced 2025-05-30 19:32:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

git: don't pass remote credentials callback to Remote::update_tips()

Browse Source 
AFAICT, the credentials callback is not used by
`Remote::update_tips()`.
This commit is contained in:
Martin von Zweigbergk 2021-11-07 15:52:51 -08:00
parent 0a43bc7088
commit bdea3ae31a
1 changed files with 1 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
lib/src/git.rs
View File

@ -146,15 +146,7 @@ pub fn fetch(
fetch_options.prune(FetchPrune::On); fetch_options.prune(FetchPrune::On);
let refspec: &[&str] = &[]; let refspec: &[&str] = &[];
remote.download(refspec, Some(&mut fetch_options))?; remote.download(refspec, Some(&mut fetch_options))?;
// The FetchOptions above ate our RemoteCallbacks so it seems we need to create remote.update_tips(None, false, git2::AutotagOption::Unspecified, None)?;
// a new instance.
let mut callbacks = create_remote_callbacks();
remote.update_tips(
Some(&mut callbacks),
false,
git2::AutotagOption::Unspecified,
None,
)?;
// TODO: We could make it optional to get the default branch since we only care // TODO: We could make it optional to get the default branch since we only care
// about it on clone. // about it on clone.
let mut default_branch = None; let mut default_branch = None;