Matt Kulukundis
8ead72e99f
formatting only: switch to Item level import ganularity
2024-08-22 14:52:54 -04:00
Yuya Nishihara
adcd78a0b7
cli: sort config/sparse subcommands in lexicographical order
2024-06-21 09:43:14 +09:00
Yuya Nishihara
20f1ba5a08
cli: rename "sub_args" variables to "args"
...
Just for consistency.
2024-06-21 09:43:14 +09:00
Yuya Nishihara
026d83b61f
cli: rename SparseArgs to SparseCommand
2024-06-21 09:43:14 +09:00
Yuya Nishihara
dcf75788e0
sparse: extract "set --reset" to subcommand
...
Since --reset conflicts with the other flags, "set --reset" seems odd.
2024-03-29 11:02:31 +09:00
Yuya Nishihara
db94848341
sparse: deduplicate edited patterns
...
Since "set --add" removes duplicated patterns, it makes sense for "edit" to do
the same thing.
2024-03-29 11:02:31 +09:00
Yuya Nishihara
28e4331787
sparse: extract "set --edit" to subcommand
...
Even though --edit can be combined with --add/--remove/--clear/--reset, I don't
think it's practically useful.
2024-03-29 11:02:31 +09:00
Yuya Nishihara
0711ac30c3
sparse: extract helper that updates sparse patterns within workspace lock
...
I assumed locked_wc.sparse_patterns() is cheap operation. If it isn't, a
locked_ws/wc should be passed to the callback instead.
2024-03-29 11:02:31 +09:00
Yuya Nishihara
fff852f136
sparse: parse and print patterns as workspace-relative paths
...
Per comment in
https://github.com/martinvonz/jj/pull/3379#pullrequestreview-1963841604
Though cwd-relative path might be useful for --remove, I don't think that's
the common use case. The new behavior is consistent with --edit.
2024-03-29 11:02:31 +09:00
Yuya Nishihara
790b5846f6
sparse: don't use io::Error to report invalid path stored in repository
...
I think it's more like data corruption, which is usually reported as an
internal error.
2024-03-28 10:52:51 +09:00
Yuya Nishihara
5c22164a26
sparse: make "sparse set --edit" accept only workspace-relative paths
...
I don't think it needs to convert absolute file paths to workspace paths.
2024-03-28 10:52:51 +09:00
Yuya Nishihara
97024e5be4
cli: extract CommandError and helper functions to new module
...
The cli_util module is big enough to slow down Emacs, so let's split it up.
This change is an easy one.
2024-03-03 01:11:46 +09:00
Yuya Nishihara
a278059c64
cli: preserve source object of internal error
...
I'm going to rewrite the error output to print source chain one by one.
The "{message}: {err}" pattern is wrapped in an error struct. InternalError
variant could be a { message, source } pair, but not all errors need an
additional message. This will also apply to UserError.
2024-02-01 16:59:44 +09:00
Daniel Ploch
4024fb4880
cli_util: improve API for editing text in a tempfile
...
Consolidates bulky tempfile code in sparse.rs and description_util.rs into cli_util.rs
2024-01-23 23:49:35 -08:00
Yuya Nishihara
0a1bc2ba42
repo_path: add stub RepoPathBuf type, update callers
...
Most RepoPath::from_internal_string() callers will be migrated to the function
that returns &RepoPath, and cloning &RepoPath won't work.
2023-11-28 07:33:28 +09:00
Antoine Cezar
6d0633443b
commands: move sparse code to sparse.rs
2023-11-03 04:45:55 +01:00
