Yuya Nishihara
1b6589a463
cli: add helper functions that set up diff renderer based on command args
...
Just for convenience. Even though WorkspaceCommandHelper is getting bloated,
I think it's okay to add thin wrapper functions there.
2024-05-14 09:36:13 +09:00
Yuya Nishihara
4d9c84a17e
diff_util: remove WorkspaceCommandHelper dependency from show functions
...
I've added a wrapper struct in order to get around too many arguments warning.
It captures &dyn Repo as CommitTemplateLanguage would do. OTOH, &Ui is passed
by argument because the caller might need &mut Ui after the renderer object was
configured.
2024-05-14 09:36:13 +09:00
Martin von Zweigbergk
dbba2edc57
commit: add a helper for returning parent tree of Commit
...
The pattern of getting the parent tree of a commit gets repeated a
bit. Let's add a helper on `Commit`.
2024-05-07 19:35:03 -07:00
Yuya Nishihara
ae70db843e
cli: warn explicit paths not exist in either of diff trees
...
Maybe we can optimize it to check paths during diffing, but I think it's okay
to add extra lookup cost at the end. The size of the path arguments is usually
small.
Closes #505
2024-04-11 00:51:19 +09:00
Yuya Nishihara
9b1eb03c73
cli: inline matcher_from_values() in favor of parse_file_patterns()
2024-04-07 19:43:29 +09:00
Yuya Nishihara
ae91adbaf4
cli: preserve RevisionArg type as much as possible
...
Just for a bit of type safety.
2024-04-03 15:30:30 +09:00
Yuya Nishihara
97024e5be4
cli: extract CommandError and helper functions to new module
...
The cli_util module is big enough to slow down Emacs, so let's split it up.
This change is an easy one.
2024-03-03 01:11:46 +09:00
Martin von Zweigbergk
9767620292
cli: restore documentation of jj diff
lost in split of commands module
...
The description of `jj diff` was lost in commit b5e4e670. We later got
a short description for it in b5e4e670. This patch restores the
original description.
2024-02-23 09:45:19 -08:00
Yuya Nishihara
c73a092759
cli: drop handling of legacy revset dag range operator
...
This basically reverts the change c183b94aeffc "cli: warn when using `:` revset
operator."
2024-02-14 10:04:56 +09:00
Ilya Grigoriev
d8df36b9a2
cli diff help: add detailed explanation of -r merge_commit
2023-11-20 20:40:01 -08:00
Ilya Grigoriev
e3852ffd55
cli diff: add short description to jj help
and jj diff -h
2023-11-20 20:40:01 -08:00
Antoine Cezar
b5e4e67090
commands: move diff code to diff.rs
2023-10-28 15:59:08 +02:00