cybercyst/nushell
1
0
Fork 0
mirror of https://github.com/nushell/nushell.git synced 2025-05-05 15:32:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

bugfix: str join outputs dates consistently (RFC2822 when possible) (#15629)

Browse Source 
Closes #11265

# Description
``str join`` outputs dates just other commands: RFC2822 by default
otherwise RFC3339 for negative dates

# User-Facing Changes

```nushell
~> 2024-01-01
# => Mon, 1 Jan 2024 00:00:00 +0000 (a year ago)
~> '3000 years ago' | date from-human
# => -0975-04-23T20:57:07.217711700+02:00 (3000 years ago)
~> [ 2024-01-01 ] | str join
# => Mon, 1 Jan 2024 00:00:00 +0000
~> [ ('3000 years ago' | date from-human) ] | str join
# => -0975-04-23T20:57:56.221269600+02:00
```

# Tests + Formatting
OK
# After Submitting
Nothing
This commit is contained in:
Loïc Riegel 2025-04-24 15:32:29 +02:00 committed by GitHub
parent 82eb1c5584
commit db261e3ed9
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
crates/nu-command/src/strings/str_/join.rs
View File

@ -1,3 +1,4 @@
use chrono::Datelike;
use nu_engine::command_prelude::*; use nu_engine::command_prelude::*;
use nu_protocol::{shell_error::io::IoError, Signals}; use nu_protocol::{shell_error::io::IoError, Signals};
@ -109,9 +110,14 @@ fn run(
Value::Error { error, .. } => { Value::Error { error, .. } => {
return Err(*error); return Err(*error);
} }
// Hmm, not sure what we actually want. Value::Date { val, .. } => {
// `to_expanded_string` formats dates as human readable which feels funny. let date_str = if val.year() >= 0 {
Value::Date { val, .. } => write!(buffer, "{val:?}").map_err(&from_io_error)?, val.to_rfc2822()
} else {
val.to_rfc3339()
};
write!(buffer, "{date_str}").map_err(&from_io_error)?
}
value => write!(buffer, "{}", value.to_expanded_string("\n", &config)) value => write!(buffer, "{}", value.to_expanded_string("\n", &config))
.map_err(&from_io_error)?, .map_err(&from_io_error)?,
} }