mirror of
https://github.com/nushell/nushell.git
synced 2025-05-21 07:03:19 +00:00
138b5af82b
This commit is more substantial than it looks: there was basically no real support for decimals before, and that impacted values all the way through. I also made Size contain a decimal instead of an integer (`1.6kb` is a reasonable thing to type), which impacted a bunch of code. The biggest impact of this commit is that it creates many more possible ways for valid nu types to fail to serialize as toml, json, etc. which typically can't support the full range of Decimal (or Bigint, which I also think we should support). This commit makes to-toml fallible, and a similar effort is necessary for the rest of the serializations. We also need to figure out how to clearly communicate to users what has happened, but failing to serialize to toml seems clearly superior to me than weird errors in basic math operations.
109 lines
3.6 KiB
Rust
109 lines
3.6 KiB
Rust
use crate::commands::WholeStreamCommand;
|
|
use crate::object::{Primitive, Value};
|
|
use crate::prelude::*;
|
|
use csv::WriterBuilder;
|
|
|
|
pub struct ToCSV;
|
|
|
|
#[derive(Deserialize)]
|
|
pub struct ToCSVArgs {
|
|
headerless: bool,
|
|
}
|
|
|
|
impl WholeStreamCommand for ToCSV {
|
|
fn name(&self) -> &str {
|
|
"to-csv"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("to-csv").switch("headerless")
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
args: CommandArgs,
|
|
registry: &CommandRegistry,
|
|
) -> Result<OutputStream, ShellError> {
|
|
args.process(registry, to_csv)?.run()
|
|
}
|
|
}
|
|
|
|
pub fn value_to_csv_value(v: &Value) -> Value {
|
|
match v {
|
|
Value::Primitive(Primitive::String(s)) => Value::Primitive(Primitive::String(s.clone())),
|
|
Value::Primitive(Primitive::Nothing) => Value::Primitive(Primitive::Nothing),
|
|
Value::Primitive(Primitive::Boolean(b)) => Value::Primitive(Primitive::Boolean(b.clone())),
|
|
Value::Primitive(Primitive::Bytes(b)) => Value::Primitive(Primitive::Bytes(b.clone())),
|
|
Value::Primitive(Primitive::Date(d)) => Value::Primitive(Primitive::Date(d.clone())),
|
|
Value::Object(o) => Value::Object(o.clone()),
|
|
Value::List(l) => Value::List(l.clone()),
|
|
Value::Block(_) => Value::Primitive(Primitive::Nothing),
|
|
_ => Value::Primitive(Primitive::Nothing),
|
|
}
|
|
}
|
|
|
|
fn to_string_helper(v: &Value) -> Result<String, Box<dyn std::error::Error>> {
|
|
match v {
|
|
Value::Primitive(Primitive::Date(d)) => Ok(d.to_string()),
|
|
Value::Primitive(Primitive::Bytes(b)) => Ok(format!("{}", b)),
|
|
Value::Primitive(Primitive::Boolean(_)) => Ok(v.as_string()?),
|
|
Value::List(_) => return Ok(String::from("[list list]")),
|
|
Value::Object(_) => return Ok(String::from("[object]")),
|
|
Value::Primitive(Primitive::String(s)) => return Ok(s.to_string()),
|
|
_ => return Err("Bad input".into()),
|
|
}
|
|
}
|
|
|
|
pub fn to_string(v: &Value) -> Result<String, Box<dyn std::error::Error>> {
|
|
match v {
|
|
Value::Object(o) => {
|
|
let mut wtr = WriterBuilder::new().from_writer(vec![]);
|
|
let mut fields: VecDeque<String> = VecDeque::new();
|
|
let mut values: VecDeque<String> = VecDeque::new();
|
|
|
|
for (k, v) in o.entries.iter() {
|
|
fields.push_back(k.clone());
|
|
values.push_back(to_string_helper(&v)?);
|
|
}
|
|
|
|
wtr.write_record(fields).expect("can not write.");
|
|
wtr.write_record(values).expect("can not write.");
|
|
|
|
return Ok(String::from_utf8(wtr.into_inner()?)?);
|
|
}
|
|
_ => return to_string_helper(&v),
|
|
}
|
|
}
|
|
|
|
fn to_csv(
|
|
ToCSVArgs { headerless }: ToCSVArgs,
|
|
RunnableContext { input, name, .. }: RunnableContext,
|
|
) -> Result<OutputStream, ShellError> {
|
|
let name_span = name;
|
|
let out = input;
|
|
|
|
Ok(out
|
|
.values
|
|
.map(move |a| match to_string(&value_to_csv_value(&a.item)) {
|
|
Ok(x) => {
|
|
let converted = if headerless {
|
|
x.lines().skip(1).collect()
|
|
} else {
|
|
x
|
|
};
|
|
|
|
ReturnSuccess::value(
|
|
Value::Primitive(Primitive::String(converted)).simple_spanned(name_span),
|
|
)
|
|
}
|
|
_ => Err(ShellError::labeled_error_with_secondary(
|
|
"Expected an object with CSV-compatible structure from pipeline",
|
|
"requires CSV-compatible input",
|
|
name_span,
|
|
format!("{} originates from here", a.item.type_name()),
|
|
a.span(),
|
|
)),
|
|
})
|
|
.to_output_stream())
|
|
}
|