Devyn Cairns 43e349a274

Mitigate the poor interaction between ndots expansion and non-path strings (#13218) ...

# Description

@hustcer reported that slashes were disappearing from external args
since #13089:

```
$> ossutil ls oss://abc/b/c
Error: invalid cloud url: "oss:/abc/b/c", please make sure the url starts with: "oss://"

$> ossutil ls 'oss://abc/b/c'
Error: oss: service returned error: StatusCode=403, ErrorCode=UserDisable, ErrorMessage="UserDisable", RequestId=66791EDEFE87B73537120838, Ec=0003-00000801, Bucket=abc, Object=
```

I narrowed this down to the ndots handling, since that does path parsing
and path reconstruction in every case. I decided to change that so that
it only activates if the string contains at least `...`, since that
would be the minimum trigger for ndots, and also to not activate it if
the string contains `://`, since it's probably undesirable for a URL.

Kind of a hack, but I'm not really sure how else we decide whether
someone wants ndots or not.

# User-Facing Changes
- bare strings not containing ndots are not modified
- bare strings containing `://` are not modified

# Tests + Formatting
Added tests to prevent regression.

2024-06-24 16:39:01 -07:00

..

assignment

Match ++= capabilities with ++ (#11130)

2023-12-07 05:46:37 +08:00

bytes

Add string/binary type color to ByteStream (#12897)

2024-05-20 00:35:32 +00:00

conversions

add --signed flag for binary into int conversions (#11902)

2024-02-27 15:05:26 +00:00

database

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

date

fix format date based on users locale (#11908)

2024-02-20 11:08:49 -06:00

debug

Force timeit to not capture stdout (#12465)

2024-04-10 13:31:29 +00:00

hash_

Bump base64 to 0.22.1 (#12757)

2024-05-04 15:56:16 +03:00

math

to json -r not removing whitespaces fix (#11948)

2024-03-20 22:14:31 +01:00

move_

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

network

Disable flaky network tests (#12010)

2024-02-28 16:28:33 +00:00

path

Fix path type using PWD from the environment (#12975)

2024-05-26 20:23:52 +03:00

platform

refactor: move du from platform to filesystem (#11852)

2024-02-15 06:55:21 +08:00

query

Feature cleanup (#7182)

2022-11-22 16:58:11 -08:00

random

remove size command in favor of str stats (#10784)

2023-11-17 06:49:19 +08:00

skip

Add string/binary type color to ByteStream (#12897)

2024-05-20 00:35:32 +00:00

str_

Improves commands that support range input (#13113)

2024-06-18 07:19:13 -05:00

take

Add string/binary type color to ByteStream (#12897)

2024-05-20 00:35:32 +00:00

url

Allow 'url join' to print username without password (#11697)

2024-01-31 16:52:23 -06:00

alias.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

all.rs

Rewrite run_external.rs (#12921)

2024-05-23 02:05:27 +00:00

any.rs

Rewrite run_external.rs (#12921)

2024-05-23 02:05:27 +00:00

append.rs

fix(nu-command/tests): further remove unnecessary pipeline() and cwd() (#8793)

2023-04-07 14:09:55 -07:00

break_.rs

fix(nu-command/tests): further remove unnecessary pipeline() and cwd() (#8793)

2023-04-07 14:09:55 -07:00

cal.rs

Suppress column index for default cal output (#13188)

2024-06-22 07:41:29 -05:00

cd.rs

Implement PWD recovery (#12779)

2024-05-10 11:06:33 -05:00

compact.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

complete.rs

Rewrite run_external.rs (#12921)

2024-05-23 02:05:27 +00:00

config_env_default.rs

Command: Add config env/nu --default to print defaults (#10480)

2023-09-25 08:00:59 -05:00

config_nu_default.rs

Command: Add config env/nu --default to print defaults (#10480)

2023-09-25 08:00:59 -05:00

continue_.rs

fix(nu-command/tests): further remove unnecessary pipeline() and cwd() (#8793)

2023-04-07 14:09:55 -07:00

debug_info.rs

Make debug info lazy (#10728)

2023-10-24 12:48:05 -05:00

def.rs

Remove --flag: bool support (#11541)

2024-01-25 14:16:49 +08:00

default.rs

Refactor first and last (#12478)

2024-04-13 14:58:54 +00:00

detect_columns.rs

Improves commands that support range input (#13113)

2024-06-18 07:19:13 -05:00

do_.rs

allow define it as a variable inside closure (#12888)

2024-05-17 00:03:13 +00:00

drop.rs

Refactor drop columns to fix issues (#10903)

2023-11-09 13:51:46 +01:00

du.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

each.rs

Prevent each from swallowing errors when eval_block returns a ListStream (#12412)

2024-05-01 17:24:54 -05:00

echo.rs

Change echo to print when not redirected (#10338)

2023-09-13 06:35:01 +12:00

empty.rs

fix(nu-command/tests): further remove unnecessary pipeline() and cwd() (#8793)

2023-04-07 14:09:55 -07:00

error_make.rs

Change the error style during tests to plain (#13061)

2024-06-18 21:37:24 -07:00

every.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

exec.rs

Isolate tests from user config (#12437)

2024-04-10 06:27:46 +08:00

export_def.rs

Removes unnecessary cwd and pipeline from various tests (#9202)

2023-05-17 18:55:26 -05:00

fill.rs

Removes unnecessary cwd and pipeline from various tests (#9202)

2023-05-17 18:55:26 -05:00

filter.rs

Fix return in filter closure eval (#12292)

2024-03-26 17:50:36 +01:00

find.rs

to json -r not removing whitespaces fix (#11948)

2024-03-20 22:14:31 +01:00

first.rs

Add string/binary type color to ByteStream (#12897)

2024-05-20 00:35:32 +00:00

flatten.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

for_.rs

Change echo to print when not redirected (#10338)

2023-09-13 06:35:01 +12:00

format.rs

Span ID Refactor (Step 2): Use SpanId of expressions in some places (#13102)

2024-06-09 12:15:53 +03:00

generate.rs

rename unfold to generate (#10770)

2023-10-19 09:30:34 -05:00

get.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

glob.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

griddle.rs

make grid throw an error when not enough columns (#12672)

2024-04-26 06:33:00 -05:00

group_by.rs

Make group-by return errors in closure (#12508)

2024-04-16 21:52:21 +02:00

headers.rs

Fix: remove unnecessary r#"..."# (#8670) (#9764)

2023-07-21 17:32:37 +02:00

help.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

histogram.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

ignore.rs

Change the ignore command to use drain() instead of collecting a value (#12120)

2024-03-08 02:18:26 -05:00

insert.rs

Remove lazy records (#12682)

2024-05-03 08:36:10 +08:00

inspect.rs

throw an error instead of a panic if no input is provided to inspect (#9259)

2023-05-22 13:54:04 -05:00

interleave.rs

Isolate tests from user config (#12437)

2024-04-10 06:27:46 +08:00

into_datetime.rs

add table -> table to into datetime (#9775)

2023-07-23 20:14:51 +02:00

into_filesize.rs

fix wrong casting with into filesize (#13110)

2024-06-10 10:43:17 +08:00

into_int.rs

add --signed flag for binary into int conversions (#11902)

2024-02-27 15:05:26 +00:00

join.rs

Removes unnecessary cwd and pipeline from various tests (#9202)

2023-05-17 18:55:26 -05:00

last.rs

Add string/binary type color to ByteStream (#12897)

2024-05-20 00:35:32 +00:00

length.rs

Suppress column index for default cal output (#13188)

2024-06-22 07:41:29 -05:00

let_.rs

add raw-string literal support (#9956)

2024-05-02 09:36:37 -04:00

lines.rs

fix panic with lines on an error (#9967)

2023-08-09 14:12:58 +02:00

loop_.rs

Change echo to print when not redirected (#10338)

2023-09-13 06:35:01 +12:00

ls.rs

Allow ls works inside dir with [] brackets (#12625)

2024-05-06 14:01:32 +08:00

match_.rs

Allow comments in match blocks (#11717)

2024-02-08 07:22:42 +08:00

merge.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

mktemp.rs

Add mktemp command (#11005)

2023-11-17 19:30:53 -06:00

mod.rs

Make which-support feature non-optional (#13125)

2024-06-12 20:04:12 -05:00

mut_.rs

add raw-string literal support (#9956)

2024-05-02 09:36:37 -04:00

nu_check.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

open.rs

Remove dataframes crate and feature (#12889)

2024-05-20 17:22:08 +00:00

par_each.rs

Fix: remove unnecessary r#"..."# (#8670) (#9764)

2023-07-21 17:32:37 +02:00

parse.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

prepend.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

print.rs

Clean up tests containing unnecessary cwd: tokens (#9692)

2023-07-17 18:43:51 +02:00

range.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

redirection.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

reduce.rs

Improve with-env robustness (#12523)

2024-04-16 19:08:58 +08:00

reject.rs

Remove list of cell path support for select and reject (#11859)

2024-02-15 07:49:48 -06:00

rename.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

return_.rs

Isolate tests from user config (#12437)

2024-04-10 06:27:46 +08:00

reverse.rs

Clean up tests containing unnecessary cwd: tokens (#9692)

2023-07-17 18:43:51 +02:00

rm.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

roll.rs

Fix: remove unnecessary r#"..."# (#8670) (#9764)

2023-07-21 17:32:37 +02:00

rotate.rs

Fix panic in rotate; Add safe record creation function (#11718)

2024-02-03 13:23:16 +02:00

run_external.rs

Mitigate the poor interaction between ndots expansion and non-path strings (#13218)

2024-06-24 16:39:01 -07:00

save.rs

collect: don't require a closure (#12788)

2024-05-17 18:46:03 +02:00

select.rs

Add sys subcommands (#12747)

2024-05-06 23:20:27 +00:00

semicolon.rs

Slim down tests (#9021)

2023-04-28 13:25:44 +02:00

seq_char.rs

Slim down tests (#9021)

2023-04-28 13:25:44 +02:00

seq_date.rs

Fix panic in seq date (#11871)

2024-02-17 10:51:20 +02:00

seq.rs

Slim down tests (#9021)

2023-04-28 13:25:44 +02:00

sort_by.rs

to json -r not removing whitespaces fix (#11948)

2024-03-20 22:14:31 +01:00

sort.rs

Fix: remove unnecessary r#"..."# (#8670) (#9764)

2023-07-21 17:32:37 +02:00

source_env.rs

Rewrite run_external.rs (#12921)

2024-05-23 02:05:27 +00:00

split_by.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

split_column.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

split_row.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00

table.rs

Try to preserve the ordering of elements in from toml (#13045)

2024-06-05 08:00:39 +08:00

tee.rs

Add tee command for operating on copies of streams (#11928)

2024-02-28 17:08:31 -06:00

terminal.rs

Add is-terminal to determine if stdin/out/err are a terminal (#10970)

2023-11-21 20:48:39 -06:00

to_text.rs

Make to text stream ListStreams (#7577)

2022-12-22 16:38:07 -08:00

touch.rs

Fix touch --reference using PWD from the environment (#12976)

2024-05-26 20:24:00 +03:00

transpose.rs

Slim down tests (#9021)

2023-04-28 13:25:44 +02:00

try_.rs

Make exit code available in catch block (#12648)

2024-04-26 16:35:08 +00:00

ucp.rs

update uutils crates (#13130)

2024-06-11 13:44:13 -05:00

ulimit.rs

FreeBSD compatibility patches (#11869)

2024-02-17 20:04:59 +01:00

umkdir.rs

Fix #12391: mkdir uses process startup directory instead of current script directory (#12394)

2024-04-04 14:23:10 +02:00

uname.rs

Initial implementation for uutils uname (#11684)

2024-03-25 16:51:50 -05:00

uniq_by.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

uniq.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

update.rs

Remove lazy records (#12682)

2024-05-03 08:36:10 +08:00

upsert.rs

Remove lazy records (#12682)

2024-05-03 08:36:10 +08:00

use_.rs

Rewrite run_external.rs (#12921)

2024-05-23 02:05:27 +00:00

where_.rs

Fix ignored clippy lints (#12160)

2024-03-11 19:46:04 +01:00

which.rs

change the output of which to be more explicit (#9646)

2023-07-20 19:10:53 -05:00

while_.rs

Change echo to print when not redirected (#10338)

2023-09-13 06:35:01 +12:00

with_env.rs

Improve with-env robustness (#12523)

2024-04-16 19:08:58 +08:00

wrap.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

zip.rs

Avoid taking unnecessary ownership of intermediates (#12740)

2024-05-04 00:53:15 +00:00