Antoine Stevan
202dfdaee2
fix panic with lines
on an error ( #9967 )
...
should close https://github.com/nushell/nushell/issues/9965
# Description
this PR implements the `todo!()` left in `lines`.
# User-Facing Changes
### before
```nushell
> open . | lines
thread 'main' panicked at 'not yet implemented', crates/nu-command/src/filters/lines.rs:248:35
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
```
### after
```nushell
> open . | lines
Error: nu:🐚 :io_error
× I/O error
help: Is a directory (os error 21)
```
# Tests + Formatting
- 🟢 `toolkit fmt`
- 🟢 `toolkit clippy`
- ⚫ `toolkit test`
- ⚫ `toolkit test stdlib`
this PR adds the `lines_on_error` test to make sure this does not happen
again 😌
# After Submitting
2023-08-09 14:12:58 +02:00
..
2023-07-17 18:43:51 +02:00
2023-08-04 06:06:00 +12:00
2023-07-17 18:43:51 +02:00
2023-07-17 18:43:51 +02:00
2023-07-12 18:12:59 +02:00
2023-07-30 22:28:48 +02:00
2023-07-31 07:47:18 -05:00
2023-08-02 10:57:58 -05:00
2022-11-22 16:58:11 -08:00
2023-07-17 18:43:51 +02:00
2023-07-17 18:43:51 +02:00
2023-08-06 06:40:44 -07:00
2023-07-17 18:43:51 +02:00
2023-07-17 18:43:51 +02:00
2023-06-21 09:33:01 +12:00
2023-05-17 18:55:26 -05:00
2023-05-17 18:55:26 -05:00
2023-04-07 14:09:55 -07:00
2023-04-07 14:09:55 -07:00
2023-04-07 14:09:55 -07:00
2023-04-07 14:09:55 -07:00
2023-04-07 14:09:55 -07:00
2023-04-07 14:09:55 -07:00
2023-07-12 18:12:59 +02:00
2023-07-21 17:32:37 +02:00
2023-04-07 14:09:55 -07:00
2023-07-21 08:25:06 -05:00
2023-07-21 17:32:37 +02:00
2023-07-14 15:20:35 +12:00
2023-07-06 08:31:31 -07:00
2023-04-07 14:09:55 -07:00
2023-04-07 14:09:55 -07:00
2023-04-07 14:09:55 -07:00
2023-04-07 14:09:55 -07:00
2022-12-22 00:33:26 +02:00
2023-05-17 18:55:26 -05:00
2023-05-17 18:55:26 -05:00
2023-06-10 16:57:26 -05:00
2023-07-05 12:30:53 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-08-02 10:57:58 -05:00
2023-07-21 17:32:37 +02:00
2023-03-15 18:54:55 +13:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-08-09 05:10:34 +12:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-05-22 13:54:04 -05:00
2023-07-23 20:14:51 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-05-17 18:55:26 -05:00
2023-07-14 15:20:35 +12:00
2023-07-17 18:43:51 +02:00
2023-07-13 09:12:20 -07:00
2023-08-09 14:12:58 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-23 20:14:51 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-08-08 06:48:13 -05:00
2023-03-15 18:54:55 +13:00
2023-07-17 18:43:51 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-04-28 13:25:44 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-17 18:43:51 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-17 18:43:51 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-04-28 13:25:44 +02:00
2023-04-28 13:25:44 +02:00
2023-04-28 13:25:44 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-04-07 06:46:11 -05:00
2023-07-27 21:32:25 +02:00
2023-08-04 13:50:47 -05:00
2022-12-22 16:38:07 -08:00
2023-07-21 17:32:37 +02:00
2023-04-28 13:25:44 +02:00
2023-07-17 18:43:51 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00
2023-07-20 19:10:53 -05:00
2023-07-17 18:43:51 +02:00
2023-07-17 18:43:51 +02:00
2023-07-21 17:32:37 +02:00
2023-07-21 17:32:37 +02:00