mirror of
https://github.com/nushell/nushell.git
synced 2025-05-15 12:14:35 +00:00
# Description The `ShellError` enum at the moment is kind of messy. Many variants are basic tuple structs where you always have to reference the implementation with its macro invocation to know which field serves which purpose. Furthermore we have both variants that are kind of redundant or either overly broad to be useful for the user to match on or overly specific with few uses. So I set out to start fixing the lacking documentation and naming to make it feasible to critically review the individual usages and fix those. Furthermore we can decide to join or split up variants that don't seem to be fit for purpose. Feel free to add review comments if you spot inconsistent use of `ShellError` variants. - Name fields on `ShellError::OperatorOverflow` - Name fields on `ShellError::PipelineMismatch` - Add doc to `ShellError::OnlySupportsThisInputType` - Name `ShellError::OnlySupportsThisInputType` - Name field on `ShellError::PipelineEmpty` - Comment about issues with `TypeMismatch*` - Fix a few `exp_input_type`s - Name fields on `ShellError::InvalidRange` # User-Facing Changes (None now, end goal more explicit and consistent error messages) # Tests + Formatting (No additional tests needed so far)
265 lines
9.1 KiB
Rust
265 lines
9.1 KiB
Rust
use crate::input_handler::{operate, CmdArgument};
|
|
use fancy_regex::{NoExpand, Regex};
|
|
use nu_engine::CallExt;
|
|
use nu_protocol::{
|
|
ast::{Call, CellPath},
|
|
engine::{Command, EngineState, Stack},
|
|
Category, Example, PipelineData, ShellError, Signature, Span, Spanned, SyntaxShape, Type,
|
|
Value,
|
|
};
|
|
|
|
struct Arguments {
|
|
all: bool,
|
|
find: Spanned<String>,
|
|
replace: Spanned<String>,
|
|
cell_paths: Option<Vec<CellPath>>,
|
|
literal_replace: bool,
|
|
no_regex: bool,
|
|
}
|
|
|
|
impl CmdArgument for Arguments {
|
|
fn take_cell_paths(&mut self) -> Option<Vec<CellPath>> {
|
|
self.cell_paths.take()
|
|
}
|
|
}
|
|
|
|
#[derive(Clone)]
|
|
pub struct SubCommand;
|
|
|
|
impl Command for SubCommand {
|
|
fn name(&self) -> &str {
|
|
"str replace"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("str replace")
|
|
.input_output_types(vec![(Type::String, Type::String)])
|
|
.vectorizes_over_list(true)
|
|
.required("find", SyntaxShape::String, "the pattern to find")
|
|
.required("replace", SyntaxShape::String, "the replacement string")
|
|
.rest(
|
|
"rest",
|
|
SyntaxShape::CellPath,
|
|
"For a data structure input, operate on strings at the given cell paths",
|
|
)
|
|
.switch("all", "replace all occurrences of the pattern", Some('a'))
|
|
.switch(
|
|
"no-expand",
|
|
"do not expand capture groups (like $name) in the replacement string",
|
|
Some('n'),
|
|
)
|
|
.switch(
|
|
"string",
|
|
"match the pattern as a substring of the input, instead of a regular expression",
|
|
Some('s'),
|
|
)
|
|
.category(Category::Strings)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Find and replace text."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["search", "shift", "switch"]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let find: Spanned<String> = call.req(engine_state, stack, 0)?;
|
|
let replace: Spanned<String> = call.req(engine_state, stack, 1)?;
|
|
let cell_paths: Vec<CellPath> = call.rest(engine_state, stack, 2)?;
|
|
let cell_paths = (!cell_paths.is_empty()).then_some(cell_paths);
|
|
let literal_replace = call.has_flag("no-expand");
|
|
let no_regex = call.has_flag("string");
|
|
|
|
let args = Arguments {
|
|
all: call.has_flag("all"),
|
|
find,
|
|
replace,
|
|
cell_paths,
|
|
literal_replace,
|
|
no_regex,
|
|
};
|
|
operate(action, args, input, call.head, engine_state.ctrlc.clone())
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Find and replace contents with capture group",
|
|
example: "'my_library.rb' | str replace '(.+).rb' '$1.nu'",
|
|
result: Some(Value::test_string("my_library.nu")),
|
|
},
|
|
Example {
|
|
description: "Find and replace all occurrences of find string",
|
|
example: "'abc abc abc' | str replace -a 'b' 'z'",
|
|
result: Some(Value::test_string("azc azc azc")),
|
|
},
|
|
Example {
|
|
description: "Find and replace all occurrences of find string in table",
|
|
example:
|
|
"[[ColA ColB ColC]; [abc abc ads]] | str replace -a 'b' 'z' ColA ColC",
|
|
result: Some(Value::List {
|
|
vals: vec![Value::Record {
|
|
cols: vec!["ColA".to_string(), "ColB".to_string(), "ColC".to_string()],
|
|
vals: vec![
|
|
Value::test_string("azc"),
|
|
Value::test_string("abc"),
|
|
Value::test_string("ads"),
|
|
],
|
|
span: Span::test_data(),
|
|
}],
|
|
span: Span::test_data(),
|
|
}),
|
|
},
|
|
Example {
|
|
description: "Find and replace contents without using the replace parameter as a regular expression",
|
|
example: r#"'dogs_$1_cats' | str replace '\$1' '$2' -n"#,
|
|
result: Some(Value::test_string("dogs_$2_cats")),
|
|
},
|
|
Example {
|
|
description: "Find and replace the first occurrence using string replacement *not* regular expressions",
|
|
example: r#"'c:\some\cool\path' | str replace 'c:\some\cool' '~' -s"#,
|
|
result: Some(Value::test_string("~\\path")),
|
|
},
|
|
Example {
|
|
description: "Find and replace all occurrences using string replacement *not* regular expressions",
|
|
example: r#"'abc abc abc' | str replace -a 'b' 'z' -s"#,
|
|
result: Some(Value::test_string("azc azc azc")),
|
|
},
|
|
Example {
|
|
description: "Find and replace with fancy-regex",
|
|
example: r#"'a successful b' | str replace '\b([sS])uc(?:cs|s?)e(ed(?:ed|ing|s?)|ss(?:es|ful(?:ly)?|i(?:ons?|ve(?:ly)?)|ors?)?)\b' '${1}ucce$2'"#,
|
|
result: Some(Value::test_string("a successful b")),
|
|
},
|
|
Example {
|
|
description: "Find and replace with fancy-regex",
|
|
example: r#"'GHIKK-9+*' | str replace '[*[:xdigit:]+]' 'z'"#,
|
|
result: Some(Value::test_string("GHIKK-z+*")),
|
|
},
|
|
|
|
]
|
|
}
|
|
}
|
|
|
|
struct FindReplace<'a>(&'a str, &'a str);
|
|
|
|
fn action(
|
|
input: &Value,
|
|
Arguments {
|
|
find,
|
|
replace,
|
|
all,
|
|
literal_replace,
|
|
no_regex,
|
|
..
|
|
}: &Arguments,
|
|
head: Span,
|
|
) -> Value {
|
|
match input {
|
|
Value::String { val, .. } => {
|
|
let FindReplace(find_str, replace_str) = FindReplace(&find.item, &replace.item);
|
|
if *no_regex {
|
|
// just use regular string replacement vs regular expressions
|
|
if *all {
|
|
Value::String {
|
|
val: val.replace(find_str, replace_str),
|
|
span: head,
|
|
}
|
|
} else {
|
|
Value::String {
|
|
val: val.replacen(find_str, replace_str, 1),
|
|
span: head,
|
|
}
|
|
}
|
|
} else {
|
|
// use regular expressions to replace strings
|
|
let regex = Regex::new(find_str);
|
|
|
|
match regex {
|
|
Ok(re) => {
|
|
if *all {
|
|
Value::String {
|
|
val: {
|
|
if *literal_replace {
|
|
re.replace_all(val, NoExpand(replace_str)).to_string()
|
|
} else {
|
|
re.replace_all(val, replace_str).to_string()
|
|
}
|
|
},
|
|
span: head,
|
|
}
|
|
} else {
|
|
Value::String {
|
|
val: {
|
|
if *literal_replace {
|
|
re.replace(val, NoExpand(replace_str)).to_string()
|
|
} else {
|
|
re.replace(val, replace_str).to_string()
|
|
}
|
|
},
|
|
span: head,
|
|
}
|
|
}
|
|
}
|
|
Err(e) => Value::Error {
|
|
error: ShellError::IncorrectValue(format!("Regex error: {e}"), find.span),
|
|
},
|
|
}
|
|
}
|
|
}
|
|
Value::Error { .. } => input.clone(),
|
|
_ => Value::Error {
|
|
error: ShellError::OnlySupportsThisInputType {
|
|
exp_input_type: "string".into(),
|
|
wrong_type: input.get_type().to_string(),
|
|
dst_span: head,
|
|
src_span: input.expect_span(),
|
|
},
|
|
},
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
use super::{action, Arguments, SubCommand};
|
|
|
|
fn test_spanned_string(val: &str) -> Spanned<String> {
|
|
Spanned {
|
|
item: String::from(val),
|
|
span: Span::test_data(),
|
|
}
|
|
}
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(SubCommand {})
|
|
}
|
|
|
|
#[test]
|
|
fn can_have_capture_groups() {
|
|
let word = Value::test_string("Cargo.toml");
|
|
|
|
let options = Arguments {
|
|
find: test_spanned_string("Cargo.(.+)"),
|
|
replace: test_spanned_string("Carga.$1"),
|
|
cell_paths: None,
|
|
literal_replace: false,
|
|
all: false,
|
|
no_regex: false,
|
|
};
|
|
|
|
let actual = action(&word, &options, Span::test_data());
|
|
assert_eq!(actual, Value::test_string("Carga.toml"));
|
|
}
|
|
}
|