mirror of
https://github.com/nushell/nushell.git
synced 2025-05-08 17:02:59 +00:00
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> https://github.com/nushell/nushell/pull/9773 introduced constants to modules and allowed to export them, but only within one level. This PR: * allows recursive exporting of constants from all submodules * fixes submodule imports in a list import pattern * makes sure exported constants are actual constants Should unblock https://github.com/nushell/nushell/pull/9678 ### Example: ```nushell module spam { export module eggs { export module bacon { export const viking = 'eats' } } } use spam print $spam.eggs.bacon.viking # prints 'eats' use spam [eggs] print $eggs.bacon.viking # prints 'eats' use spam eggs bacon viking print $viking # prints 'eats' ``` ### Limitation 1: Considering the above `spam` module, attempting to get `eggs bacon` from `spam` module doesn't work directly: ```nushell use spam [ eggs bacon ] # attempts to load `eggs`, then `bacon` use spam [ "eggs bacon" ] # obviously wrong name for a constant, but doesn't work also for commands ``` Workaround (for example): ```nushell use spam eggs use eggs [ bacon ] print $bacon.viking # prints 'eats' ``` I'm thinking I'll just leave it in, as you can easily work around this. It is also a limitation of the import pattern in general, not just constants. ### Limitation 2: `overlay use` successfully imports the constants, but `overlay hide` does not hide them, even though it seems to hide normal variables successfully. This needs more investigation. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> Allows recursive constant exports from submodules. # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used -A clippy::needless_collect -A clippy::result_large_err` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass - `cargo run -- -c "use std testing; testing run-tests --path crates/nu-std"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. -->
103 lines
3.3 KiB
Rust
103 lines
3.3 KiB
Rust
use std::path::PathBuf;
|
|
|
|
use nu_engine::{
|
|
eval_block_with_early_return, find_in_dirs_env, get_dirs_var_from_call, redirect_env, CallExt,
|
|
};
|
|
use nu_protocol::ast::Call;
|
|
use nu_protocol::engine::{Command, EngineState, Stack};
|
|
use nu_protocol::{
|
|
Category, Example, PipelineData, ShellError, Signature, Spanned, SyntaxShape, Type, Value,
|
|
};
|
|
|
|
/// Source a file for environment variables.
|
|
#[derive(Clone)]
|
|
pub struct SourceEnv;
|
|
|
|
impl Command for SourceEnv {
|
|
fn name(&self) -> &str {
|
|
"source-env"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("source-env")
|
|
.input_output_types(vec![(Type::Any, Type::Any)])
|
|
.required(
|
|
"filename",
|
|
SyntaxShape::String, // type is string to avoid automatically canonicalizing the path
|
|
"the filepath to the script file to source the environment from",
|
|
)
|
|
.category(Category::Core)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Source the environment from a source file into the current environment."
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
caller_stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let source_filename: Spanned<String> = call.req(engine_state, caller_stack, 0)?;
|
|
|
|
// Note: this hidden positional is the block_id that corresponded to the 0th position
|
|
// it is put here by the parser
|
|
let block_id: i64 = call.req_parser_info(engine_state, caller_stack, "block_id")?;
|
|
|
|
// Set the currently evaluated directory (file-relative PWD)
|
|
let file_path = if let Some(path) = find_in_dirs_env(
|
|
&source_filename.item,
|
|
engine_state,
|
|
caller_stack,
|
|
get_dirs_var_from_call(call),
|
|
)? {
|
|
PathBuf::from(&path)
|
|
} else {
|
|
return Err(ShellError::FileNotFound(source_filename.span));
|
|
};
|
|
|
|
if let Some(parent) = file_path.parent() {
|
|
let file_pwd = Value::string(parent.to_string_lossy(), call.head);
|
|
|
|
caller_stack.add_env_var("FILE_PWD".to_string(), file_pwd);
|
|
}
|
|
|
|
caller_stack.add_env_var(
|
|
"CURRENT_FILE".to_string(),
|
|
Value::string(file_path.to_string_lossy(), call.head),
|
|
);
|
|
|
|
// Evaluate the block
|
|
let block = engine_state.get_block(block_id as usize).clone();
|
|
let mut callee_stack = caller_stack.gather_captures(engine_state, &block.captures);
|
|
|
|
let result = eval_block_with_early_return(
|
|
engine_state,
|
|
&mut callee_stack,
|
|
&block,
|
|
input,
|
|
call.redirect_stdout,
|
|
call.redirect_stderr,
|
|
);
|
|
|
|
// Merge the block's environment to the current stack
|
|
redirect_env(engine_state, caller_stack, &callee_stack);
|
|
|
|
// Remove the file-relative PWD
|
|
caller_stack.remove_env_var(engine_state, "FILE_PWD");
|
|
caller_stack.remove_env_var(engine_state, "CURRENT_FILE");
|
|
|
|
result
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![Example {
|
|
description: "Sources the environment from foo.nu in the current context",
|
|
example: r#"source-env foo.nu"#,
|
|
result: None,
|
|
}]
|
|
}
|
|
}
|