mirror of
https://github.com/nushell/nushell.git
synced 2025-05-28 02:21:19 +00:00
# Description Continuing from #12568, this PR further reduces the size of `Expr` from 64 to 40 bytes. It also reduces `Expression` from 128 to 96 bytes and `Type` from 32 to 24 bytes. This was accomplished by: - for `Expr` with multiple fields (e.g., `Expr::Thing(A, B, C)`), merging the fields into new AST struct types and then boxing this struct (e.g. `Expr::Thing(Box<ABC>)`). - replacing `Vec<T>` with `Box<[T]>` in multiple places. `Expr`s and `Expression`s should rarely be mutated, if at all, so this optimization makes sense. By reducing the size of these types, I didn't notice a large performance improvement (at least compared to #12568). But this PR does reduce the memory usage of nushell. My config is somewhat light so I only noticed a difference of 1.4MiB (38.9MiB vs 37.5MiB). --------- Co-authored-by: Stefan Holderbach <sholderbach@users.noreply.github.com>
140 lines
4.1 KiB
Rust
140 lines
4.1 KiB
Rust
use nu_cmd_base::input_handler::{operate, CmdArgument};
|
|
use nu_engine::command_prelude::*;
|
|
|
|
use nu_utils::IgnoreCaseExt;
|
|
|
|
struct Arguments {
|
|
substring: String,
|
|
cell_paths: Option<Vec<CellPath>>,
|
|
case_insensitive: bool,
|
|
}
|
|
|
|
impl CmdArgument for Arguments {
|
|
fn take_cell_paths(&mut self) -> Option<Vec<CellPath>> {
|
|
self.cell_paths.take()
|
|
}
|
|
}
|
|
|
|
#[derive(Clone)]
|
|
|
|
pub struct SubCommand;
|
|
|
|
impl Command for SubCommand {
|
|
fn name(&self) -> &str {
|
|
"str starts-with"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("str starts-with")
|
|
.input_output_types(vec![
|
|
(Type::String, Type::Bool),
|
|
(Type::List(Box::new(Type::String)), Type::List(Box::new(Type::Bool))),
|
|
(Type::table(), Type::table()),
|
|
(Type::record(), Type::record()),
|
|
])
|
|
.allow_variants_without_examples(true)
|
|
.required("string", SyntaxShape::String, "The string to match.")
|
|
.rest(
|
|
"rest",
|
|
SyntaxShape::CellPath,
|
|
"For a data structure input, check strings at the given cell paths, and replace with result.",
|
|
)
|
|
.switch("ignore-case", "search is case insensitive", Some('i'))
|
|
.category(Category::Strings)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Check if an input starts with a string."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["prefix", "match", "find", "search"]
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let substring: Spanned<String> = call.req(engine_state, stack, 0)?;
|
|
let cell_paths: Vec<CellPath> = call.rest(engine_state, stack, 1)?;
|
|
let cell_paths = (!cell_paths.is_empty()).then_some(cell_paths);
|
|
let args = Arguments {
|
|
substring: substring.item,
|
|
cell_paths,
|
|
case_insensitive: call.has_flag(engine_state, stack, "ignore-case")?,
|
|
};
|
|
operate(action, args, input, call.head, engine_state.ctrlc.clone())
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Checks if input string starts with 'my'",
|
|
example: "'my_library.rb' | str starts-with 'my'",
|
|
result: Some(Value::test_bool(true)),
|
|
},
|
|
Example {
|
|
description: "Checks if input string starts with 'Car'",
|
|
example: "'Cargo.toml' | str starts-with 'Car'",
|
|
result: Some(Value::test_bool(true)),
|
|
},
|
|
Example {
|
|
description: "Checks if input string starts with '.toml'",
|
|
example: "'Cargo.toml' | str starts-with '.toml'",
|
|
result: Some(Value::test_bool(false)),
|
|
},
|
|
Example {
|
|
description: "Checks if input string starts with 'cargo', case-insensitive",
|
|
example: "'Cargo.toml' | str starts-with --ignore-case 'cargo'",
|
|
result: Some(Value::test_bool(true)),
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
fn action(
|
|
input: &Value,
|
|
Arguments {
|
|
substring,
|
|
case_insensitive,
|
|
..
|
|
}: &Arguments,
|
|
head: Span,
|
|
) -> Value {
|
|
match input {
|
|
Value::String { val: s, .. } => {
|
|
let starts_with = if *case_insensitive {
|
|
s.to_folded_case().starts_with(&substring.to_folded_case())
|
|
} else {
|
|
s.starts_with(substring)
|
|
};
|
|
Value::bool(starts_with, head)
|
|
}
|
|
Value::Error { .. } => input.clone(),
|
|
_ => Value::error(
|
|
ShellError::OnlySupportsThisInputType {
|
|
exp_input_type: "string".into(),
|
|
wrong_type: input.get_type().to_string(),
|
|
dst_span: head,
|
|
src_span: input.span(),
|
|
},
|
|
head,
|
|
),
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(SubCommand {})
|
|
}
|
|
}
|