mirror of
https://github.com/nushell/nushell.git
synced 2025-05-31 23:25:16 +00:00
# Description This PR creates a new `Record` type to reduce duplicate code and possibly bugs as well. (This is an edited version of #9648.) - `Record` implements `FromIterator` and `IntoIterator` and so can be iterated over or collected into. For example, this helps with conversions to and from (hash)maps. (Also, no more `cols.iter().zip(vals)`!) - `Record` has a `push(col, val)` function to help insure that the number of columns is equal to the number of values. I caught a few potential bugs thanks to this (e.g. in the `ls` command). - Finally, this PR also adds a `record!` macro that helps simplify record creation. It is used like so: ```rust record! { "key1" => some_value, "key2" => Value::string("text", span), "key3" => Value::int(optional_int.unwrap_or(0), span), "key4" => Value::bool(config.setting, span), } ``` Since macros hinder formatting, etc., the right hand side values should be relatively short and sweet like the examples above. Where possible, prefer `record!` or `.collect()` on an iterator instead of multiple `Record::push`s, since the first two automatically set the record capacity and do less work overall. # User-Facing Changes Besides the changes in `nu-protocol` the only other breaking changes are to `nu-table::{ExpandedTable::build_map, JustTable::kv_table}`.
160 lines
5.0 KiB
Rust
160 lines
5.0 KiB
Rust
use nu_engine::CallExt;
|
|
use nu_protocol::ast::{Call, Expr, Expression};
|
|
use nu_protocol::engine::{Command, EngineState, Stack};
|
|
use nu_protocol::{
|
|
record, Category, DataSource, Example, IntoPipelineData, PipelineData, PipelineMetadata,
|
|
Record, ShellError, Signature, Span, SyntaxShape, Type, Value,
|
|
};
|
|
|
|
#[derive(Clone)]
|
|
pub struct Metadata;
|
|
|
|
impl Command for Metadata {
|
|
fn name(&self) -> &str {
|
|
"metadata"
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Get the metadata for items in the stream."
|
|
}
|
|
|
|
fn signature(&self) -> nu_protocol::Signature {
|
|
Signature::build("metadata")
|
|
.input_output_types(vec![(Type::Any, Type::Record(vec![]))])
|
|
.allow_variants_without_examples(true)
|
|
.optional(
|
|
"expression",
|
|
SyntaxShape::Any,
|
|
"the expression you want metadata for",
|
|
)
|
|
.category(Category::Debug)
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let arg = call.positional_nth(0);
|
|
let head = call.head;
|
|
|
|
match arg {
|
|
Some(Expression {
|
|
expr: Expr::FullCellPath(full_cell_path),
|
|
span,
|
|
..
|
|
}) => {
|
|
if full_cell_path.tail.is_empty() {
|
|
match &full_cell_path.head {
|
|
Expression {
|
|
expr: Expr::Var(var_id),
|
|
..
|
|
} => {
|
|
let origin = stack.get_var_with_origin(*var_id, *span)?;
|
|
|
|
Ok(build_metadata_record(&origin, &input.metadata(), head)
|
|
.into_pipeline_data())
|
|
}
|
|
_ => {
|
|
let val: Value = call.req(engine_state, stack, 0)?;
|
|
Ok(build_metadata_record(&val, &input.metadata(), head)
|
|
.into_pipeline_data())
|
|
}
|
|
}
|
|
} else {
|
|
let val: Value = call.req(engine_state, stack, 0)?;
|
|
Ok(build_metadata_record(&val, &input.metadata(), head).into_pipeline_data())
|
|
}
|
|
}
|
|
Some(_) => {
|
|
let val: Value = call.req(engine_state, stack, 0)?;
|
|
Ok(build_metadata_record(&val, &input.metadata(), head).into_pipeline_data())
|
|
}
|
|
None => {
|
|
let mut record = Record::new();
|
|
if let Some(x) = input.metadata().as_deref() {
|
|
match x {
|
|
PipelineMetadata {
|
|
data_source: DataSource::Ls,
|
|
} => record.push("source", Value::string("ls", head)),
|
|
PipelineMetadata {
|
|
data_source: DataSource::HtmlThemes,
|
|
} => record.push("source", Value::string("into html --list", head)),
|
|
PipelineMetadata {
|
|
data_source: DataSource::Profiling(values),
|
|
} => record.push("profiling", Value::list(values.clone(), head)),
|
|
}
|
|
}
|
|
|
|
Ok(Value::record(record, head).into_pipeline_data())
|
|
}
|
|
}
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Get the metadata of a variable",
|
|
example: "let a = 42; metadata $a",
|
|
result: None,
|
|
},
|
|
Example {
|
|
description: "Get the metadata of the input",
|
|
example: "ls | metadata",
|
|
result: None,
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
fn build_metadata_record(
|
|
arg: &Value,
|
|
metadata: &Option<Box<PipelineMetadata>>,
|
|
head: Span,
|
|
) -> Value {
|
|
let mut record = Record::new();
|
|
|
|
if let Ok(span) = arg.span() {
|
|
record.push(
|
|
"span",
|
|
Value::record(
|
|
record! {
|
|
"start" => Value::int(span.start as i64,span),
|
|
"end" => Value::int(span.end as i64, span),
|
|
},
|
|
head,
|
|
),
|
|
);
|
|
}
|
|
|
|
if let Some(x) = metadata.as_deref() {
|
|
match x {
|
|
PipelineMetadata {
|
|
data_source: DataSource::Ls,
|
|
} => record.push("source", Value::string("ls", head)),
|
|
PipelineMetadata {
|
|
data_source: DataSource::HtmlThemes,
|
|
} => record.push("source", Value::string("into html --list", head)),
|
|
PipelineMetadata {
|
|
data_source: DataSource::Profiling(values),
|
|
} => record.push("profiling", Value::list(values.clone(), head)),
|
|
}
|
|
}
|
|
|
|
Value::record(record, head)
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(Metadata {})
|
|
}
|
|
}
|