mirror of
https://github.com/nushell/nushell.git
synced 2025-05-15 20:24:34 +00:00
This PR closes [Issue #13482](https://github.com/nushell/nushell/issues/13482) # Description This PR tend to make all math function to be constant. # User-Facing Changes The math commands now can be used as constant methods. ### Some Example ``` > const MODE = [3 3 9 12 12 15] | math mode > $MODE ╭───┬────╮ │ 0 │ 3 │ │ 1 │ 12 │ ╰───┴────╯ > const LOG = [16 8 4] | math log 2 > $LOG ╭───┬──────╮ │ 0 │ 4.00 │ │ 1 │ 3.00 │ │ 2 │ 2.00 │ ╰───┴──────╯ > const VAR = [1 3 5] | math variance > $VAR 2.6666666666666665 ``` # Tests + Formatting Tests are added for all of the math command to test there constant behavior. I mostly focused on the actual user experience, not the correctness of the methods and algorithms. # After Submitting I think this change don't require any additional documentation. Feel free to correct me in this topic please.
174 lines
4.9 KiB
Rust
174 lines
4.9 KiB
Rust
use crate::math::{avg::average, utils::run_with_function};
|
|
use nu_engine::command_prelude::*;
|
|
use std::cmp::Ordering;
|
|
|
|
#[derive(Clone)]
|
|
pub struct SubCommand;
|
|
|
|
impl Command for SubCommand {
|
|
fn name(&self) -> &str {
|
|
"math median"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("math median")
|
|
.input_output_types(vec![
|
|
(Type::List(Box::new(Type::Number)), Type::Number),
|
|
(Type::List(Box::new(Type::Duration)), Type::Duration),
|
|
(Type::List(Box::new(Type::Filesize)), Type::Filesize),
|
|
(Type::Range, Type::Number),
|
|
(Type::table(), Type::record()),
|
|
(Type::record(), Type::record()),
|
|
])
|
|
.allow_variants_without_examples(true)
|
|
.category(Category::Math)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Computes the median of a list of numbers."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["middle", "statistics"]
|
|
}
|
|
|
|
fn is_const(&self) -> bool {
|
|
true
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
_engine_state: &EngineState,
|
|
_stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
run_with_function(call, input, median)
|
|
}
|
|
|
|
fn run_const(
|
|
&self,
|
|
_working_set: &StateWorkingSet,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
run_with_function(call, input, median)
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Compute the median of a list of numbers",
|
|
example: "[3 8 9 12 12 15] | math median",
|
|
result: Some(Value::test_float(10.5)),
|
|
},
|
|
Example {
|
|
description: "Compute the medians of the columns of a table",
|
|
example: "[{a: 1 b: 3} {a: 2 b: -1} {a: -3 b: 5}] | math median",
|
|
result: Some(Value::test_record(record! {
|
|
"a" => Value::test_int(1),
|
|
"b" => Value::test_int(3),
|
|
})),
|
|
},
|
|
Example {
|
|
description: "Find the median of a list of file sizes",
|
|
example: "[5KB 10MB 200B] | math median",
|
|
result: Some(Value::test_filesize(5 * 1_000)),
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
enum Pick {
|
|
MedianAverage,
|
|
Median,
|
|
}
|
|
|
|
pub fn median(values: &[Value], span: Span, head: Span) -> Result<Value, ShellError> {
|
|
let take = if values.len() % 2 == 0 {
|
|
Pick::MedianAverage
|
|
} else {
|
|
Pick::Median
|
|
};
|
|
|
|
let mut sorted = vec![];
|
|
|
|
for item in values {
|
|
sorted.push(item.clone());
|
|
}
|
|
|
|
if let Some(Err(values)) = values
|
|
.windows(2)
|
|
.map(|elem| {
|
|
if elem[0].partial_cmp(&elem[1]).is_none() {
|
|
return Err(ShellError::OperatorMismatch {
|
|
op_span: head,
|
|
lhs_ty: elem[0].get_type().to_string(),
|
|
lhs_span: elem[0].span(),
|
|
rhs_ty: elem[1].get_type().to_string(),
|
|
rhs_span: elem[1].span(),
|
|
});
|
|
}
|
|
Ok(elem[0].partial_cmp(&elem[1]).unwrap_or(Ordering::Equal))
|
|
})
|
|
.find(|elem| elem.is_err())
|
|
{
|
|
return Err(values);
|
|
}
|
|
|
|
sorted.sort_by(|a, b| a.partial_cmp(b).unwrap_or(Ordering::Equal));
|
|
|
|
match take {
|
|
Pick::Median => {
|
|
let idx = (values.len() as f64 / 2.0).floor() as usize;
|
|
let out = sorted
|
|
.get(idx)
|
|
.ok_or_else(|| ShellError::UnsupportedInput {
|
|
msg: "Empty input".to_string(),
|
|
input: "value originates from here".into(),
|
|
msg_span: head,
|
|
input_span: span,
|
|
})?;
|
|
Ok(out.clone())
|
|
}
|
|
Pick::MedianAverage => {
|
|
let idx_end = values.len() / 2;
|
|
let idx_start = idx_end - 1;
|
|
|
|
let left = sorted
|
|
.get(idx_start)
|
|
.ok_or_else(|| ShellError::UnsupportedInput {
|
|
msg: "Empty input".to_string(),
|
|
input: "value originates from here".into(),
|
|
msg_span: head,
|
|
input_span: span,
|
|
})?
|
|
.clone();
|
|
|
|
let right = sorted
|
|
.get(idx_end)
|
|
.ok_or_else(|| ShellError::UnsupportedInput {
|
|
msg: "Empty input".to_string(),
|
|
input: "value originates from here".into(),
|
|
msg_span: head,
|
|
input_span: span,
|
|
})?
|
|
.clone();
|
|
|
|
average(&[left, right], span, head)
|
|
}
|
|
}
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod test {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(SubCommand {})
|
|
}
|
|
}
|