mirror of
https://github.com/nushell/nushell.git
synced 2025-05-29 19:11:18 +00:00
a52386e837
# Description Our `ShellError` at the moment has a `std::mem::size_of<ShellError>` of 136 bytes (on AMD64). As a result `Value` directly storing the struct also required 136 bytes (thanks to alignment requirements). This change stores the `Value::Error` `ShellError` on the heap. Pro: - Value now needs just 80 bytes - Should be 1 cacheline less (still at least 2 cachelines) Con: - More small heap allocations when dealing with `Value::Error` - More heap fragmentation - Potential for additional required memcopies # Further code changes Includes a small refactor of `try` due to a type mismatch in its large match. # User-Facing Changes None for regular users. Plugin authors may have to update their matches on `Value` if they use `nu-protocol` Needs benchmarking to see if there is a benefit in real world workloads. **Update** small improvements in runtime for workloads with high volume of values. Significant reduction in maximum resident set size, when many values are held in memory. # Tests + Formatting
27 lines
947 B
Rust
27 lines
947 B
Rust
use chrono::{DateTime, FixedOffset, Local, LocalResult, TimeZone};
|
|
use nu_protocol::{ShellError, Span, Value};
|
|
|
|
pub(crate) fn parse_date_from_string(
|
|
input: &str,
|
|
span: Span,
|
|
) -> Result<DateTime<FixedOffset>, Value> {
|
|
match dtparse::parse(input) {
|
|
Ok((native_dt, fixed_offset)) => {
|
|
let offset = match fixed_offset {
|
|
Some(fo) => fo,
|
|
None => *(Local::now().offset()),
|
|
};
|
|
match offset.from_local_datetime(&native_dt) {
|
|
LocalResult::Single(d) => Ok(d),
|
|
LocalResult::Ambiguous(d, _) => Ok(d),
|
|
LocalResult::None => Err(Value::Error {
|
|
error: Box::new(ShellError::DatetimeParseError(input.to_string(), span)),
|
|
}),
|
|
}
|
|
}
|
|
Err(_) => Err(Value::Error {
|
|
error: Box::new(ShellError::DatetimeParseError(input.to_string(), span)),
|
|
}),
|
|
}
|
|
}
|