Ian Manske fa5d7babb9

Fix replacement closures for update, insert, and upsert (#11258) ...

# Description
This PR addresses #11204 which points out that using a closure for the
replacement value with `update`, `insert`, or `upsert` does not work for
lists.

# User-Facing Changes
- Replacement closures should now work for lists in `upsert`, `insert`,
and `update`. E.g., `[0] | update 0 {|i| $i + 1 }` now gives `[1]`
instead of an unhelpful error.
- `[1 2] | insert 4 20` no longer works. Before, this would give `[1, 2,
null, null, 20]`, but now it gives an error. This was done to match the
intended behavior in `Value::insert_data_at_cell_path`, whereas the
behavior before was probably unintentional. Following
`Value::insert_data_at_cell_path`, inserting at the end of a list is
also fine, so the valid indices for `upsert` and `insert` are
`0..=length` just like `Vec::insert` or list inserts in other languages.

# Tests + Formatting
Added tests for `upsert`, `insert`, and `update`:
- Replacement closures for lists, list streams, records, and tables
- Other list stream tests

2023-12-09 15:22:45 -06:00

..

assignment

Match ++= capabilities with ++ (#11130)

2023-12-07 05:46:37 +08:00

conversions

Fix 9156 endian consistency (#9873)

2023-08-24 07:08:58 -05:00

date

rename from date format to format date (#9902)

2023-08-04 06:06:00 +12:00

hash_

Clean up tests containing unnecessary cwd: tokens (#9692)

2023-07-17 18:43:51 +02:00

math

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

move_

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

network

Add checks for ports (#11214)

2023-12-03 08:07:15 -06:00

path

bump rust-toolchain to 1.72.1 (#11079)

2023-11-16 15:14:45 -06:00

platform

Add long options for platform and random (#10776)

2023-10-19 22:04:33 +02:00

query

Feature cleanup (#7182)

2022-11-22 16:58:11 -08:00

random

remove size command in favor of str stats (#10784)

2023-11-17 06:49:19 +08:00

skip

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

str_

use to_lowercase in str downcase (#10850)

2023-10-27 19:16:17 +02:00

take

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

url

Add url decode command (#10611)

2023-10-05 18:43:58 +02:00

alias.rs

feat: Add default docs for aliases, generated from the command they point to (#10825)

2023-12-04 20:56:46 +02:00

all.rs

Removes unnecessary cwd and pipeline from various tests (#9202)

2023-05-17 18:55:26 -05:00

any.rs

Removes unnecessary cwd and pipeline from various tests (#9202)

2023-05-17 18:55:26 -05:00

append.rs

fix(nu-command/tests): further remove unnecessary pipeline() and cwd() (#8793)

2023-04-07 14:09:55 -07:00

break_.rs

fix(nu-command/tests): further remove unnecessary pipeline() and cwd() (#8793)

2023-04-07 14:09:55 -07:00

cal.rs

fix(nu-command/tests): further remove unnecessary pipeline() and cwd() (#8793)

2023-04-07 14:09:55 -07:00

cd.rs

bump rust-toolchain to 1.72.1 (#11079)

2023-11-16 15:14:45 -06:00

compact.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

config_env_default.rs

Command: Add config env/nu --default to print defaults (#10480)

2023-09-25 08:00:59 -05:00

config_nu_default.rs

Command: Add config env/nu --default to print defaults (#10480)

2023-09-25 08:00:59 -05:00

continue_.rs

fix(nu-command/tests): further remove unnecessary pipeline() and cwd() (#8793)

2023-04-07 14:09:55 -07:00

cp.rs

Send only absolute paths to uu_cp (#11080)

2023-11-17 07:30:57 +08:00

debug_info.rs

Make debug info lazy (#10728)

2023-10-24 12:48:05 -05:00

def.rs

Do not create help for wrapped command (#11235)

2023-12-05 13:04:36 -06:00

default.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

detect_columns.rs

Use long options for string (#10777)

2023-10-19 22:08:09 +02:00

do_.rs

remove the $nothing variable (#10478)

2023-09-26 18:49:28 +02:00

drop.rs

Refactor drop columns to fix issues (#10903)

2023-11-09 13:51:46 +01:00

each.rs

REFACTOR: move the 0% commands to nu-cmd-extra (#9404)

2023-07-06 08:31:31 -07:00

echo.rs

Change echo to print when not redirected (#10338)

2023-09-13 06:35:01 +12:00

empty.rs

fix(nu-command/tests): further remove unnecessary pipeline() and cwd() (#8793)

2023-04-07 14:09:55 -07:00

error_make.rs

Refactor error make (#10923)

2023-11-03 10:09:33 -05:00

every.rs

fix(nu-command/tests): further remove unnecessary pipeline() and cwd() (#8793)

2023-04-07 14:09:55 -07:00

exec.rs

Add "fall-through" signatures (#7527)

2022-12-22 00:33:26 +02:00

export_def.rs

Removes unnecessary cwd and pipeline from various tests (#9202)

2023-05-17 18:55:26 -05:00

fill.rs

Removes unnecessary cwd and pipeline from various tests (#9202)

2023-05-17 18:55:26 -05:00

find.rs

Fix find puts extra cols into record (#9397)

2023-06-10 16:57:26 -05:00

first.rs

remove --column from length command and remove record processing (#10091)

2023-08-23 16:03:26 -05:00

flatten.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

for_.rs

Change echo to print when not redirected (#10338)

2023-09-13 06:35:01 +12:00

format.rs

update format signature to allow record to be passed in (#9898)

2023-08-02 10:57:58 -05:00

generate.rs

rename unfold to generate (#10770)

2023-10-19 09:30:34 -05:00

get.rs

Fix get -i ignoring errors for only the first cellpath (#11213)

2023-12-02 11:01:08 -06:00

glob.rs

fix clippy (#10659)

2023-10-10 03:31:15 +13:00

group_by.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

headers.rs

Fix: remove unnecessary r#"..."# (#8670) (#9764)

2023-07-21 17:32:37 +02:00

help.rs

Tests: clean up unnecessary use of pipeline() (#10170)

2023-08-31 23:10:29 +02:00

histogram.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

insert.rs

Fix replacement closures for update, insert, and upsert (#11258)

2023-12-09 15:22:45 -06:00

inspect.rs

throw an error instead of a panic if no input is provided to inspect (#9259)

2023-05-22 13:54:04 -05:00

into_datetime.rs

add table -> table to into datetime (#9775)

2023-07-23 20:14:51 +02:00

into_filesize.rs

Update internal use of decimal to float (#10333)

2023-09-13 23:53:55 +02:00

into_int.rs

fix some new chrono warnings (#10384)

2023-09-15 15:46:25 -05:00

join.rs

Removes unnecessary cwd and pipeline from various tests (#9202)

2023-05-17 18:55:26 -05:00

last.rs

remove --column from length command and remove record processing (#10091)

2023-08-23 16:03:26 -05:00

length.rs

Spanned Value step 1: span all value cases (#10042)

2023-08-25 08:48:05 +12:00

let_.rs

fix 'let' to properly redirect (#10360)

2023-09-14 10:18:29 +12:00

lines.rs

fix panic with lines on an error (#9967)

2023-08-09 14:12:58 +02:00

loop_.rs

Change echo to print when not redirected (#10338)

2023-09-13 06:35:01 +12:00

ls.rs

treat path contains '?' as pattern (#10142)

2023-09-03 19:25:00 -05:00

match_.rs

Support pattern matching null literals (#10829)

2023-10-25 06:30:45 +08:00

merge.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

mkdir.rs

Fix: remove unnecessary r#"..."# (#8670) (#9764)

2023-07-21 17:32:37 +02:00

mktemp.rs

Add mktemp command (#11005)

2023-11-17 19:30:53 -06:00

mod.rs

Add is-terminal to determine if stdin/out/err are a terminal (#10970)

2023-11-21 20:48:39 -06:00

mut_.rs

Fix: remove unnecessary r#"..."# (#8670) (#9764)

2023-07-21 17:32:37 +02:00

nu_check.rs

Use long options for string (#10777)

2023-10-19 22:08:09 +02:00

open.rs

allow multiple extensions (#10593)

2023-10-13 13:45:36 -05:00

par_each.rs

Fix: remove unnecessary r#"..."# (#8670) (#9764)

2023-07-21 17:32:37 +02:00

parse.rs

Clippy in tests (#10394)

2023-09-16 21:49:10 +02:00

prepend.rs

Fix warnings and old names (#8457)

2023-03-15 18:54:55 +13:00

print.rs

Clean up tests containing unnecessary cwd: tokens (#9692)

2023-07-17 18:43:51 +02:00

range.rs

Fix: remove unnecessary r#"..."# (#8670) (#9764)

2023-07-21 17:32:37 +02:00

redirection.rs

When using redirection, if a command generates non-zero exit code, the script should stop running (#11191)

2023-11-30 18:52:02 +01:00

reduce.rs

Add long options for filters (#10641)

2023-10-08 13:12:46 +02:00

reject.rs

Disallow duplicated columns in table literals (#10875)

2023-11-01 21:25:35 +01:00

rename.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

return_.rs

allow early return outside of main (#10514)

2023-09-28 18:49:42 +02:00

reverse.rs

Clean up tests containing unnecessary cwd: tokens (#9692)

2023-07-17 18:43:51 +02:00

rm.rs

Fix rm path handling (#11064)

2023-11-17 07:30:15 +08:00

roll.rs

Fix: remove unnecessary r#"..."# (#8670) (#9764)

2023-07-21 17:32:37 +02:00

rotate.rs

Clean up tests containing unnecessary cwd: tokens (#9692)

2023-07-17 18:43:51 +02:00

run_external.rs

Limit run-external --redirect-combine sh test to not(Windows) (#10905)

2023-11-07 16:35:24 +08:00

save.rs

Fix wrong path expansion in save (#10046)

2023-08-18 20:45:10 +03:00

select.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

semicolon.rs

Slim down tests (#9021)

2023-04-28 13:25:44 +02:00

seq_char.rs

Slim down tests (#9021)

2023-04-28 13:25:44 +02:00

seq.rs

Slim down tests (#9021)

2023-04-28 13:25:44 +02:00

sort_by.rs

Fix: remove unnecessary r#"..."# (#8670) (#9764)

2023-07-21 17:32:37 +02:00

sort.rs

Fix: remove unnecessary r#"..."# (#8670) (#9764)

2023-07-21 17:32:37 +02:00

source_env.rs

Tests: clean up unnecessary use of pipeline() (#10170)

2023-08-31 23:10:29 +02:00

split_by.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

split_column.rs

Use long options for string (#10777)

2023-10-19 22:08:09 +02:00

split_row.rs

Simplify rawstrings in tests (#10180)

2023-09-01 00:08:27 +02:00

table.rs

Fix #11047 (#11054)

2023-11-16 05:28:54 -06:00

terminal.rs

Add is-terminal to determine if stdin/out/err are a terminal (#10970)

2023-11-21 20:48:39 -06:00

to_text.rs

Make to text stream ListStreams (#7577)

2022-12-22 16:38:07 -08:00

touch.rs

Fix: remove unnecessary r#"..."# (#8670) (#9764)

2023-07-21 17:32:37 +02:00

transpose.rs

Slim down tests (#9021)

2023-04-28 13:25:44 +02:00

try_.rs

Clean up tests containing unnecessary cwd: tokens (#9692)

2023-07-17 18:43:51 +02:00

ucp.rs

Cp target expansion (#11152)

2023-11-25 09:42:20 -06:00

umkdir.rs

Add umkdir command (#10785)

2023-10-30 07:59:48 -05:00

uniq_by.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

uniq.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

update.rs

Fix replacement closures for update, insert, and upsert (#11258)

2023-12-09 15:22:45 -06:00

upsert.rs

Fix replacement closures for update, insert, and upsert (#11258)

2023-12-09 15:22:45 -06:00

use_.rs

Error on use path item1 item2, if item1 is not a module (#11183)

2023-12-05 11:38:45 +01:00

where_.rs

remove warnings in nu_command tests (#10145)

2023-08-29 13:18:52 -07:00

which.rs

change the output of which to be more explicit (#9646)

2023-07-20 19:10:53 -05:00

while_.rs

Change echo to print when not redirected (#10338)

2023-09-13 06:35:01 +12:00

with_env.rs

Clean up tests containing unnecessary cwd: tokens (#9692)

2023-07-17 18:43:51 +02:00

wrap.rs

Remove file I/O from tests that don't need it (#11182)

2023-11-29 23:21:34 +01:00

zip.rs

Fix: remove unnecessary r#"..."# (#8670) (#9764)

2023-07-21 17:32:37 +02:00