mirror of
https://github.com/nushell/nushell.git
synced 2025-05-17 05:04:34 +00:00
<!-- if this PR closes one or more issues, you can automatically link the PR with them by using one of the [*linking keywords*](https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword), e.g. - this PR should close #xxxx - fixes #xxxx you can also mention related issues, PRs or discussions! --> Related meta-issue: #10239. # Description <!-- Thank you for improving Nushell. Please, check our [contributing guide](../CONTRIBUTING.md) and talk to the core team before making major changes. Description of your pull request goes here. **Provide examples and/or screenshots** if your changes affect the user experience. --> This PR will modify some `str`-related commands so that they can be evaluated at parse time. See the following list for those implemented by this pr. # User-Facing Changes <!-- List of all changes that impact the user experience here. This helps us keep track of breaking changes. --> Available now: - `str` subcommands - `trim` - `contains` - `distance` - `ends-with` - `expand` - `index-of` - `join` - `replace` - `reverse` - `starts-with` - `stats` - `substring` - `capitalize` - `downcase` - `upcase` - `split` subcommands - `chars` - `column` - `list` - `row` - `words` - `format` subcommands - `date` - `duration` - `filesize` - string related commands - `parse` - `detect columns` - `encode` & `decode` # Tests + Formatting <!-- Don't forget to add tests that cover your changes. Make sure you've run and fixed any issues with these commands: - `cargo fmt --all -- --check` to check standard code formatting (`cargo fmt --all` applies these changes) - `cargo clippy --workspace -- -D warnings -D clippy::unwrap_used` to check that you're using the standard code style - `cargo test --workspace` to check that all tests pass (on Windows make sure to [enable developer mode](https://learn.microsoft.com/en-us/windows/apps/get-started/developer-mode-features-and-debugging)) - `cargo run -- -c "use toolkit.nu; toolkit test stdlib"` to run the tests for the standard library > **Note** > from `nushell` you can also use the `toolkit` as follows > ```bash > use toolkit.nu # or use an `env_change` hook to activate it automatically > toolkit check pr > ``` --> Unresolved questions: - [ ] Is there any routine of testing const expressions? I haven't found any yet. - [ ] Is const expressions required to behave just like there non-const version, like what rust promises? # After Submitting <!-- If your PR had any user-facing changes, update [the documentation](https://github.com/nushell/nushell.github.io) after the PR is merged, if necessary. This will help us keep the docs up to date. --> Unresolved questions: - [ ] Do const commands need special marks in the docs?
217 lines
6.9 KiB
Rust
217 lines
6.9 KiB
Rust
use nu_cmd_base::input_handler::{operate, CmdArgument};
|
|
use nu_engine::command_prelude::*;
|
|
|
|
struct Arguments {
|
|
format_value: String,
|
|
float_precision: usize,
|
|
cell_paths: Option<Vec<CellPath>>,
|
|
}
|
|
|
|
impl CmdArgument for Arguments {
|
|
fn take_cell_paths(&mut self) -> Option<Vec<CellPath>> {
|
|
self.cell_paths.take()
|
|
}
|
|
}
|
|
|
|
#[derive(Clone)]
|
|
pub struct FormatDuration;
|
|
|
|
impl Command for FormatDuration {
|
|
fn name(&self) -> &str {
|
|
"format duration"
|
|
}
|
|
|
|
fn signature(&self) -> Signature {
|
|
Signature::build("format duration")
|
|
.input_output_types(vec![
|
|
(Type::Duration, Type::String),
|
|
(
|
|
Type::List(Box::new(Type::Duration)),
|
|
Type::List(Box::new(Type::String)),
|
|
),
|
|
(Type::table(), Type::table()),
|
|
])
|
|
.allow_variants_without_examples(true)
|
|
.required(
|
|
"format value",
|
|
SyntaxShape::String,
|
|
"The unit in which to display the duration.",
|
|
)
|
|
.rest(
|
|
"rest",
|
|
SyntaxShape::CellPath,
|
|
"For a data structure input, format duration at the given cell paths.",
|
|
)
|
|
.category(Category::Strings)
|
|
}
|
|
|
|
fn usage(&self) -> &str {
|
|
"Outputs duration with a specified unit of time."
|
|
}
|
|
|
|
fn search_terms(&self) -> Vec<&str> {
|
|
vec!["convert", "display", "pattern", "human readable"]
|
|
}
|
|
|
|
fn is_const(&self) -> bool {
|
|
true
|
|
}
|
|
|
|
fn run(
|
|
&self,
|
|
engine_state: &EngineState,
|
|
stack: &mut Stack,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let format_value = call
|
|
.req::<Value>(engine_state, stack, 0)?
|
|
.coerce_into_string()?
|
|
.to_ascii_lowercase();
|
|
let cell_paths: Vec<CellPath> = call.rest(engine_state, stack, 1)?;
|
|
let cell_paths = (!cell_paths.is_empty()).then_some(cell_paths);
|
|
let float_precision = engine_state.config.float_precision as usize;
|
|
let arg = Arguments {
|
|
format_value,
|
|
float_precision,
|
|
cell_paths,
|
|
};
|
|
operate(
|
|
format_value_impl,
|
|
arg,
|
|
input,
|
|
call.head,
|
|
engine_state.ctrlc.clone(),
|
|
)
|
|
}
|
|
|
|
fn run_const(
|
|
&self,
|
|
working_set: &StateWorkingSet,
|
|
call: &Call,
|
|
input: PipelineData,
|
|
) -> Result<PipelineData, ShellError> {
|
|
let format_value = call
|
|
.req_const::<Value>(working_set, 0)?
|
|
.coerce_into_string()?
|
|
.to_ascii_lowercase();
|
|
let cell_paths: Vec<CellPath> = call.rest_const(working_set, 1)?;
|
|
let cell_paths = (!cell_paths.is_empty()).then_some(cell_paths);
|
|
let float_precision = working_set.permanent().config.float_precision as usize;
|
|
let arg = Arguments {
|
|
format_value,
|
|
float_precision,
|
|
cell_paths,
|
|
};
|
|
operate(
|
|
format_value_impl,
|
|
arg,
|
|
input,
|
|
call.head,
|
|
working_set.permanent().ctrlc.clone(),
|
|
)
|
|
}
|
|
|
|
fn examples(&self) -> Vec<Example> {
|
|
vec![
|
|
Example {
|
|
description: "Convert µs duration to the requested second duration as a string",
|
|
example: "1000000µs | format duration sec",
|
|
result: Some(Value::test_string("1 sec")),
|
|
},
|
|
Example {
|
|
description: "Convert durations to µs duration as strings",
|
|
example: "[1sec 2sec] | format duration µs",
|
|
result: Some(Value::test_list(vec![
|
|
Value::test_string("1000000 µs"),
|
|
Value::test_string("2000000 µs"),
|
|
])),
|
|
},
|
|
Example {
|
|
description: "Convert duration to µs as a string if unit asked for was us",
|
|
example: "1sec | format duration us",
|
|
result: Some(Value::test_string("1000000 µs")),
|
|
},
|
|
]
|
|
}
|
|
}
|
|
|
|
fn format_value_impl(val: &Value, arg: &Arguments, span: Span) -> Value {
|
|
let inner_span = val.span();
|
|
match val {
|
|
Value::Duration { val: inner, .. } => {
|
|
let duration = *inner;
|
|
let float_precision = arg.float_precision;
|
|
match convert_inner_to_unit(duration, &arg.format_value, span, inner_span) {
|
|
Ok(d) => {
|
|
let unit = if &arg.format_value == "us" {
|
|
"µs"
|
|
} else {
|
|
&arg.format_value
|
|
};
|
|
if d.fract() == 0.0 {
|
|
Value::string(format!("{} {}", d, unit), inner_span)
|
|
} else {
|
|
Value::string(format!("{:.float_precision$} {}", d, unit), inner_span)
|
|
}
|
|
}
|
|
Err(e) => Value::error(e, inner_span),
|
|
}
|
|
}
|
|
Value::Error { .. } => val.clone(),
|
|
_ => Value::error(
|
|
ShellError::OnlySupportsThisInputType {
|
|
exp_input_type: "filesize".into(),
|
|
wrong_type: val.get_type().to_string(),
|
|
dst_span: span,
|
|
src_span: val.span(),
|
|
},
|
|
span,
|
|
),
|
|
}
|
|
}
|
|
|
|
fn convert_inner_to_unit(
|
|
val: i64,
|
|
to_unit: &str,
|
|
span: Span,
|
|
value_span: Span,
|
|
) -> Result<f64, ShellError> {
|
|
match to_unit {
|
|
"ns" => Ok(val as f64),
|
|
"us" => Ok(val as f64 / 1000.0),
|
|
"µs" => Ok(val as f64 / 1000.0), // Micro sign
|
|
"μs" => Ok(val as f64 / 1000.0), // Greek small letter
|
|
"ms" => Ok(val as f64 / 1000.0 / 1000.0),
|
|
"sec" => Ok(val as f64 / 1000.0 / 1000.0 / 1000.0),
|
|
"min" => Ok(val as f64 / 1000.0 / 1000.0 / 1000.0 / 60.0),
|
|
"hr" => Ok(val as f64 / 1000.0 / 1000.0 / 1000.0 / 60.0 / 60.0),
|
|
"day" => Ok(val as f64 / 1000.0 / 1000.0 / 1000.0 / 60.0 / 60.0 / 24.0),
|
|
"wk" => Ok(val as f64 / 1000.0 / 1000.0 / 1000.0 / 60.0 / 60.0 / 24.0 / 7.0),
|
|
"month" => Ok(val as f64 / 1000.0 / 1000.0 / 1000.0 / 60.0 / 60.0 / 24.0 / 30.0),
|
|
"yr" => Ok(val as f64 / 1000.0 / 1000.0 / 1000.0 / 60.0 / 60.0 / 24.0 / 365.0),
|
|
"dec" => Ok(val as f64 / 10.0 / 1000.0 / 1000.0 / 1000.0 / 60.0 / 60.0 / 24.0 / 365.0),
|
|
|
|
_ => Err(ShellError::CantConvertToDuration {
|
|
details: to_unit.to_string(),
|
|
dst_span: span,
|
|
src_span: value_span,
|
|
help: Some(
|
|
"supported units are ns, us/µs, ms, sec, min, hr, day, wk, month, yr, and dec"
|
|
.to_string(),
|
|
),
|
|
}),
|
|
}
|
|
}
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
|
|
#[test]
|
|
fn test_examples() {
|
|
use crate::test_examples;
|
|
|
|
test_examples(FormatDuration)
|
|
}
|
|
}
|