cybercyst/go
1
0
Fork 0
mirror of https://github.com/golang/go.git synced 2025-05-05 15:43:04 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

internal/memoize: add a go:nocheckptr annotation to (*Store).get

Browse Source 
Fixes golang/go#35125

Change-Id: I08251b94a44fbc2324f6edc883d9d687b45a00b0
Reviewed-on: https://go-review.googlesource.com/c/tools/+/203078
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
This commit is contained in:
Brad Fitzpatrick 2019-10-24 04:25:51 +00:00
parent 2b779830f9
commit 7b6f5d95f3
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
internal/memoize/memoize.go
View File

@ -121,6 +121,8 @@ func (s *Store) Cached(key interface{}) interface{} {
return h.Cached() return h.Cached()
} }
//go:nocheckptr
// nocheckptr because: https://github.com/golang/go/issues/35125#issuecomment-545671062
func (s *Store) get(key interface{}) *Handle { func (s *Store) get(key interface{}) *Handle {
// this must be called with the store mutex already held // this must be called with the store mutex already held
e, found := s.entries[key] e, found := s.entries[key]